Block

Code review thread

A code review pattern: paste in code, the assistant returns a critique with markdown commentary and a side-by-side before/after.

Snippet → review with diff

Review this — it's stuck in a recursion loop.

session.ts (before)typescript

function refreshSession(token: string) {
  if (!token) throw new Error('no token');
  const decoded = verifyToken(token);
  if (decoded.expired) {
    return refreshSession(decoded.refreshToken);
  }
  return decoded;
}

The cycle is the recursive call — refreshSession calls itself with the refresh token, which goes back through verifyToken. Fix: decode without verifying, then exchange the refresh token via a separate code path.

session/refresh.ts (after)suggested

// session/refresh.ts — extracted to break the cycle
function refreshSession(token: string) {
  const decoded = decodeToken(token);
  if (decoded.expired) {
    return exchangeRefreshToken(decoded.refreshToken);
  }
  return decoded;
}

<!-- User message: prose + the snippet inside one bubble -->
<div hlmMessage align="end">
  <div hlmMessageContent>
    <div hlmBubble>
      <div hlmBubbleContent>Review this — it's stuck in a recursion loop.</div>
    </div>
    <pk-code-block>
      <pk-code-block-group class="border-b px-3 py-1.5 text-[11px]">
        <span class="font-mono">session.ts (before)</span>
        <span class="uppercase tracking-wider">typescript</span>
      </pk-code-block-group>
      <pk-code-block-code [code]="before" language="ts" />
    </pk-code-block>
  </div>
</div>

<!-- Assistant: markdown commentary + suggested fix -->
<div hlmMessage>
  <div hlmMessageAvatar>
    <hlm-avatar>
      <span hlmAvatarFallback>AI</span>
    </hlm-avatar>
  </div>
  <div hlmMessageContent>
    <div hlmBubble variant="secondary">
      <div hlmBubbleContent class="prose dark:prose-invert">
        <pk-markdown content="The cycle is the recursive call — **fix:** decode without verifying, then exchange via a separate code path." />
      </div>
    </div>
    <pk-code-block>
      <pk-code-block-group class="border-b px-3 py-1.5 text-[11px]">
        <span class="font-mono">session/refresh.ts (after)</span>
        <span class="text-primary uppercase">suggested</span>
      </pk-code-block-group>
      <pk-code-block-code [code]="after" language="ts" />
    </pk-code-block>
  </div>
</div>